Repository navigation
Improve plan-feature shared-artifact coverage - #359
Conversation
Reviewer's GuideThis PR updates plan-feature to analyze shared artifacts across every producer, consumer, fallback, and on-demand path, then carry concrete paths, validation, tests, and eval coverage into tasks while surfacing scope conflicts. It adds targeted multi-writer evaluation fixtures and records the new requirement as constraint 1.106, alongside workflow documentation for Jira defaults and Serena naming. Flow diagram for shared-artifact coverage in plan-featureflowchart LR
A["Feature acceptance criterion"] --> B["Step 3: map shared artifact"]
B --> C["Trace all producers and writers"]
B --> D["Trace consumers and presentations"]
B --> E["Trace fallback and on-demand paths"]
C --> F["Step 5: reconcile into tasks"]
D --> F
E --> F
F --> G["Files, validation, tests, and eval coverage"]
F --> H["Surface scope conflicts"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. If the new planning guidance overstates which producer or consumer paths are affected, it could lead to unnecessary or incomplete Jira tasks being created. Those issues remain after a revert, but they are bounded and can be corrected or closed; reverting stops future plans from using the guidance.
Eval ResultsSource head: 5270a81 Eval Results: plan-feature
Failed Assertionseval-5: 1 failing assertion
Pass rate: 99% · Tokens: 75,128 · Duration: 859s Baseline ( Generated by sdlc-workflow/run-evals v0.13.10 |
ruromero
added
ok-to-test
|
🤖 Finished Verify Pr · ❌ Failure (ensuring provider "vertex-ai": provider create "vertex-ai" failed: exit status 1 (output: Error: × code: 'Client specified an invalid argument', message: "provider │ credentials are not declared by pr…) · Started 6:41 PM UTC · Completed 6:41 PM UTC Commit: Effort: high |
|
🤖 Finished Verify Pr · ❌ Failure (ensuring provider "vertex-ai": provider create "vertex-ai" failed: exit status 1 (output: Error: × code: 'Client specified an invalid argument', message: "provider │ credentials are not declared by pr…) · Started 6:49 PM UTC · Completed 6:49 PM UTC Commit: Effort: high |
Trace shared artifacts through primary, fallback, on-demand, and consumer paths. Add eval coverage and record the constraint. Implements TC-7146 Assisted-by: Claude Code
Require eval plans to test stable identifiers and existing update behavior. Implements TC-7146 Assisted-by: Claude Code
Require path enumeration in impact maps and keep excluded writers out of task scope until clarified. Implements TC-7146 Assisted-by: Claude Code
Require the multi-writer eval to check documentation of every population path. Implements TC-7146 Assisted-by: Claude Code
github-actions
Bot
removed
the
ok-to-test
|
[sdlc-workflow/verify-pr] Re: @sourcery-ai review — Classified as suggestion — the review provides a general risk caveat and requests human review, but does not request a specific code change. No sub-task created. |
Verification Report for TC-7146 (commit 5270a81)
Overall: WARNThe requested shared-artifact guidance and positive/conflicting-scope evals pass. The warnings are the two additional files outside the Jira task’s listed file set and one pre-existing eval-5 assertion failure. This comment was AI-generated by sdlc-workflow/verify-pr v0.13.10. |
|
🤖 Finished Verify Pr · ✅ Success · Started 12:41 PM UTC · Completed 12:49 PM UTC Commit: Runtime: claude · Model: claude-opus-4-8 · Effort: high · Cost: $4.38 |
Verification Report for TC-7146 (commit 5270a81)
Overall: WARNThe requested shared-artifact planning guidance (Step 3 producer/consumer analysis and Step 5 task-decomposition coverage), the new constraint 1.106, and the two new eval cases (positive full-coverage eval-7 and conflicting-scope eval-8) are all present and pass. The warnings are non-blocking: two files were changed outside the task's listed set ( This comment was AI-generated by sdlc-workflow/verify-pr v0.13.10. |
Summary
Implements TC-7146.
Evidence
uv run --with pytest --with pyyaml --with 'jsonschema[format]' --no-project -- python -m pytest plugins/sdlc-workflow/scripts/ -q— 740 passed, 3 skipped (temporary environment; no repo dependency changes).uvx skillsaw— no error-level findings (warnings only).claude plugin validate plugins/sdlc-workflow— passed with an icon warning.evals/plan-feature/README.mdstill lists cases 1–4; left unchanged because it is outside TC-7146's approved file scope.Merge Danger
Door: Two-way; the guidance and eval additions are revertible.
Blast Radius: Low; affects planning outputs and project workflow documentation.
Summary by Sourcery
Ensure plan-feature plans account for complete shared-artifact lifecycle coverage and expose scope conflicts before claiming acceptance criteria are satisfied.
New Features:
Enhancements:
Documentation:
Tests: