You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @KubeKyrie , thanks for the PR and for the detailed write-up — and sorry for the
slow response.
Heads-up: we just merged a large internal iteration into main (#17), which
substantially reworks the Task execution path. As part of that change, the shell
scripts this PR patches (ray_head.sh / ray_worker.sh) have been removed, and
the sshd process is now declared in Go rather than assembled in shell:
entrypoint is rlark-tools supervisor, which builds a ProcessDeclaration
(primary ray-launcher, optional sshd)
the sshd arguments are constructed in apps/rlark/pkg/agent/controllers/task/environment/kubernetes/ssh/ssh.go
using long flags (--port=<n>, --authorized-key-file=<path>), so the -port / pflag shorthand mismatch you found can no longer occur
this is now covered by unit tests (ssh/ssh_test.go, supervisor/assembler_test.go)
So the root cause you reported is fixed on main, just via a different route.
If something remains, update the PR accordingly and re-run the checks.
If it's fully covered, feel free to close this PR — that's completely fine.
Either way, the report was genuinely valuable: it was a real regression
(the flag → pflag migration silently broke -port), and it was invisible in
practice because the failure happened in a backgrounded nohup process whose
error went to a container-local log file. Thanks for catching and documenting it.
Happy to answer any questions. Thanks again for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--port rather than -port