Repository navigation
Conversation
LLVM 21 renamed the downstream -parallel-jobs= option to --offload-jobs=. Prefer the supported spelling and keep the old one as a fallback for older toolchains, so the parallel compile path is not silently dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CMakeLists.txtprobes and passes the downstream-only Clang option-parallel-jobs=12. ROCm LLVM removed that spelling (ROCm/llvm-project#3764); ROCm 7.2'samdclang++ --helpdocuments--offload-jobs=<value>instead. On a compiler without the old alias the probe fails and the parallel offload path is silently skipped.This prefers
--offload-jobs=12and keeps-parallel-jobs=12as a fallback for older toolchains.Testing
AMD Instinct MI350X VF (gfx950), ROCm 7.2.0:
The configure line confirms the new spelling is selected by the compiler check; the full build links
TransferBenchsuccessfully.