Skip to content

Gate comfyui-01/02/03 on a required Windows lane, not only the optional self-hosted one #689

Open

Description

@jussielo-amd

Context

#629 asked for the ComfyUI install/status e2e scenarios to run on Windows. PR #637 fixed comfyui-01/comfyui-02/comfyui-03's fixtures so they're hermetic (no GPU, no network) and Windows-portable, and dropped their @requires-os:linux tag.

A round of automated review on that PR (comment) pointed out that Windows coverage for these three scenarios currently depends entirely on the optional, self-hosted E2E tests (Strix Halo, Windows) lane (e2e-selfhosted.yml), which:

  • only runs when changes.serve is true,
  • is not in the required-checks list for main (confirmed live against the branch protection rules at the time),
  • runs on a shared self-hosted runner pool that has been backed up across several rounds of that PR's review.

So nothing currently stops a PR from merging, and closing #629, without a single Windows run of these scenarios ever having executed — it just happens to have run for #637 itself after some delay.

Proposal

comfyui-01/comfyui-02/comfyui-03 don't need a GPU or network access (that's the whole point of their fixture fix), so they could run in the required, hosted windows-build-and-test job instead — which today only runs the lifecycle scenarios (E2E_INCLUDE_LIFECYCLE=1 E2E_ONLY_LIFECYCLE=1). Moving or adding these three scenarios to that job's selection would make #629's fix an enforced guarantee rather than one that depends on an optional, often-backlogged lane.

Scope

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions