Skip to content

e2e: ungate comfyui-05/-06/-07/-09/-10/-13 from @requires-os:linux #697

Open

Description

@jussielo-amd

Current behavior

#629 asked to either ungate every Linux-only ComfyUI install/status scenario in comfyui.feature or document why full e2e coverage of that path is Linux-only by design. #637 did the first half: comfyui-01/-02/-03 now plant Windows-portable fixtures and dropped @requires-os:linux.

That PR's plant_ready_runtime change also made comfyui-05/-06/-07/-09/-10/-13 (the reinstall scenarios) stop needing a POSIX shell for their runtime Python — they already plant the same Windows-portable fake-python stand-in comfyui-01/-02/-03 use. They still carry @requires-os:linux because nobody has run their reinstall behavior on Windows yet, not because of a remaining shell dependency.

Expected behavior

Drop @requires-os:linux from comfyui-05/-06/-07/-09/-10/-13 and confirm them on the Windows e2e lane, closing the remaining part of #629's ask. (comfyui-04, -08, -11, -12 stay Linux-only for their own, separate reasons: a real PTY, or a sh -c/shell-shim dependency documented in comfyui.feature's header comments.)

Scope note

Split out of #637 to keep that PR scoped to the fixture fix #629 asked for; this is the remaining half.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions