Skip to content

e2e: synchronous rocm calls in async steps freeze every other scenario #720

Open

Description

@rominf

cucumber polls every in-flight scenario from a single task, and most steps run the rocm binary synchronously (run_rocm and its siblings, about 180 call sites). While one scenario's command runs, no other scenario is polled at all. Any step with a time window can then fail for reasons that have nothing to do with the product.

Recent cases:

Each of those fixes compensates in one step: #662 runs the request on its own task, and #719 extends the deadline by the time the driver was stalled. The root fix is to make the rocm-running helpers async (for example tokio::process, or spawn_blocking plus .await), so a long command in one scenario no longer stops the others.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions