Skip to content

test(workflows): fail a pwsh step that can mask a native failure #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rominf merged 3 commits into from
Oct 21, 2026
Merged

test(workflows): fail a pwsh step that can mask a native failure #658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef44c63
test(workflows): fail a pwsh step that can mask a native failure
rominf Oct 13, 2026
6b4bd3f
refactor(xtask): share one step_name helper between job_steps and pws…
rominf Oct 14, 2026
c56db1a
test(xtask): split pwsh statements at top-level `;` and past a here-s…
rominf Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,7 +728,9 @@ jobs:

# One command per step: pwsh carries on past a failing native command and
# the step reports only the last command's exit code, so a multi-line
# block would let an early self-test fail unseen.
# block would let an early self-test fail unseen. Enforced for every pwsh
# step by `no_pwsh_step_lets_a_failing_native_command_pass_unseen` in
# xtask/src/workflow_contract.rs.
- name: Acceptance harness self-test (ComfyUI)
if: needs.changes.outputs.heavy == 'true'
shell: pwsh
Expand Down
Loading
Loading