Skip to content

Fix empty ASSOC_SPW_ID column in CASA-generated MS files - #1732

Open
JoeMichail wants to merge 4 commits into
RadioAstronomySoftwareGroup:mainfrom
JoeMichail:fix-empty-assoc-spw-id
Open

JoeMichail wants to merge 4 commits into
RadioAstronomySoftwareGroup:mainfrom
JoeMichail:fix-empty-assoc-spw-id

Conversation

@JoeMichail

@JoeMichail JoeMichail commented Oct 20, 2026 •

Copy link
Copy Markdown

Fixes missing IndexError for empty ASSOC_SPW_ID column with CASA-generated MS files.

Description

Adds IndexError to the list of caught errors.

Motivation and Context

CASA-generated MeasurementSets instantiate the ASSOC_SPW_ID column but leaves it empty. pyuvdata fills the column, but lacked the ability to open the CASA-generated MeasurementSets as it threw an IndexError. This PR adds IndexError to the list of caught errors to include this issue.

Closes #1731

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change
  • Other

Checklist:

Bug fix checklist:

  • My fix includes a new test that breaks as a result of the bug (if possible).
  • I have updated the CHANGELOG.

@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.95%. Comparing base (06f40c2) to head (03910de).

Additional details and impacted files
@@             Coverage Diff             @@
##              main    #1732      +/-   ##
===========================================
- Coverage   100.00%   98.95%   -1.05%     
===========================================
  Files           71       71              
  Lines        23921    23921              
===========================================
- Hits         23921    23671     -250     
- Misses           0      250     +250     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoeMichail
JoeMichail force-pushed the fix-empty-assoc-spw-id branch from b62c7d3 to b1f2963 Compare October 21, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

read_ms throws IndexError when opening CASA split() MS

2 participants