Conversation
…r TPM and Secure Boot status
…move related tests
Summarize the catalog, WinPE startup, and diagnostic updates included in this branch and align the README version with the module manifest.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved catalog export, compatibility, selection, validation, and diagnostic-stream issues remain.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (3)
What changed in this PR
Updates operating system catalog processing, Windows build metadata, diagnostics, WinPE profile metadata, and release documentation.
Changes:
- Adds validated, timestamped catalog refresh support.
- Centralizes Windows build conversion and updates catalog mappings.
- Standardizes diagnostics and updates module version to
26.9.25.1.
| File | Reviewed changes |
|---|---|
README.md |
Updates module version. |
OSDCloud/public/WinOS/Deploy-OSDCloud.ps1 |
Updates deployment version output. |
OSDCloud/private/Update-OSDCloudCoreCatalogOS.ps1 |
Adds catalog download, validation, and publication. |
OSDCloud/private/core-operatingsystem/Initialize-ModuleCoreOperatingSystems.ps1 |
Updates timestamped catalog initialization. |
OSDCloud/private/core-operatingsystem/Get-OSDCoreOperatingSystems.ps1 |
Updates operating-system catalog retrieval. |
OSDCloud/private/core-operatingsystem/Get-OSDCloudCoreOperatingSystems.ps1 |
Updates catalog operating-system handling. |
OSDCloud/private/core-operatingsystem/ConvertTo-OSDCoreOperatingSystemInfo.ps1 |
Centralizes Windows build metadata conversion. |
OSDCloud/private/core-device/Sync-OSDCoreDateTime.ps1 |
Standardizes clock diagnostics. |
OSDCloud/private/core-device/Initialize-OSDCoreDevice.ps1 |
Updates device diagnostics. |
OSDCloud/OSDCloud.psm1 |
Excludes test files during module loading. |
OSDCloud/OSDCloud.psd1 |
Updates module metadata and version. |
OSDCloud/core/winpestartup-profiles/OSDCloud.json |
Adds WinPE profile metadata. |
CHANGELOG.md |
Documents release changes. |
.github/instructions/osdcloud-catalog-update.instructions.md |
Documents timestamped catalog conventions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -0,0 +1,391 @@ | |||
| function Update-OSDCloudCoreCatalogOS { | |||
| } | ||
|
|
||
| $cabPath = Join-Path $temporaryDirectory 'products.cab' | ||
| Invoke-WebRequest -Uri $cabUri -OutFile $cabPath -Headers @{ Accept = '*/*' } |
Comment on lines
+122
to
+123
| if ($file.Name -notmatch '^(?<MajorBuild>\d{5})\.(?<Revision>0|[1-9]\d*)\.(?<Timestamp>\d{6}-\d{4})\.xml$') { | ||
| $message = "Operating system catalog filename '$($file.FullName)' does not match '<major>.<ubr>.<yyMMdd>-<HHmm>.xml'." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
git diff --check