Skip to content

fix(upload-queue): prevent duplicate uploads and abort on remove - #985

Merged
thlpkee20-wq merged 1 commit into
RevoraOrg:masterfrom
ByteForce-Labs:fix/upload-queue-duplicate-943
Oct 24, 2026
Merged

thlpkee20-wq merged 1 commit into
RevoraOrg:masterfrom
ByteForce-Labs:fix/upload-queue-duplicate-943

Conversation

@ByteForce-Labs

@ByteForce-Labs ByteForce-Labs commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Closes #943

  • Track in-flight uploads in a ref and skip duplicates in uploadFiles/retryFile.
  • Extend Uploader to accept optional AbortSignal; create AbortController per upload, abort on remove and unmount.
  • Ignore progress/status updates after removal/abort to avoid state updates for removed items.
  • Keep behavior for existing callers (signal optional).

@thlpkee20-wq
thlpkee20-wq merged commit 86d9862 into RevoraOrg:master Oct 24, 2026
4 of 5 checks passed
thlpkee20-wq added a commit that referenced this pull request Oct 24, 2026
- stellar: type NETWORK as NetworkType so the TESTNET/PUBLIC comparison
  behind APP_STELLAR_NETWORK typechecks (#988).
- explorer tests: expect the app's testnet network as the default
  Stellar Expert network, matching #988.
- financial terms (#987): add the locale parameter to validateField (and
  validateInvestmentRange) that the hook/form already pass; restore the
  simple single-comma heuristic ("123,456" was parsed as 123.456); make
  locale separator detection robust for locales that only group large
  numbers (es); cover locale parsing and step validation in tests.
- payout reschedule (#986): use the local calendar day for the past-date
  check, drop dead code, link the date error via aria-describedby; update
  tests to use future dates and the new unchanged-date / reset-on-reopen
  behaviour, and cover empty/past/unchanged validation.
- upload queue (#985): simplify abort/stale handling (finally already
  cleans up), drop unreachable guards; test duplicate prevention, abort on
  remove and on unmount, and late-settling uploads.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(upload-queue): uploadFiles can start duplicate uploads for the same file, and removing a file does not abort its upload

3 participants