Repository navigation
fix(financial-terms): locale number parsing and step validation - #987
Merged
thlpkee20-wq merged 3 commits intoOct 24, 2026
Merged
thlpkee20-wq merged 3 commits into
thlpkee20-wq merged 3 commits into
Conversation
thlpkee20-wq
added a commit
that referenced
this pull request
Oct 24, 2026
- stellar: type NETWORK as NetworkType so the TESTNET/PUBLIC comparison behind APP_STELLAR_NETWORK typechecks (#988). - explorer tests: expect the app's testnet network as the default Stellar Expert network, matching #988. - financial terms (#987): add the locale parameter to validateField (and validateInvestmentRange) that the hook/form already pass; restore the simple single-comma heuristic ("123,456" was parsed as 123.456); make locale separator detection robust for locales that only group large numbers (es); cover locale parsing and step validation in tests. - payout reschedule (#986): use the local calendar day for the past-date check, drop dead code, link the date error via aria-describedby; update tests to use future dates and the new unchanged-date / reset-on-reopen behaviour, and cover empty/past/unchanged validation. - upload queue (#985): simplify abort/stale handling (finally already cleans up), drop unreachable guards; test duplicate prevention, abort on remove and on unmount, and late-settling uploads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #918