Repository navigation
fix(annotator): reject invalid zero-dimension assets - #905
Merged
Merged
Conversation
parseAssetDescriptor now requires positive whole-pixel dimensions, the annotation page shows an error instead of building a 0x0 frame from a null width/height, and the browser suggestion executor refuses a source whose frame is not at least 1x1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #877
Problem
AnnotationPagecoerced a null asset width/height to0(?? 0), building a 0×0 editor frame that then reached browser suggestion preparation.Change
parseAssetDescriptorrequires positive whole-pixel dimensions.AnnotationPageshows anASSET_FRAME_INVALIDerror state (with retry) for an unmeasured or zero-sized asset instead of coercing.BrowserSuggestionExecutorrefuses a source smaller than 1×1 before the model runs (BROWSER_ASSET_FRAME_INVALID, with curated prose inREFUSAL_PROSE).Assetrejects zero/negative dimensions. The server's accept-unmeasured behavior in prompt bounds checking is documented and left unchanged.Tests
New coverage for the parser, the page (unmeasured and 0×0), the executor, refusal prose, and the kernel
Assetinvariant. Touched suites, typecheck and lint pass locally.Notes