Repository navigation
feat: add a REST thumbnail backfill job, resolve connections in the kernel from the CLI, share the project pre-label loop - #909
Merged
Conversation
…ernel from the CLI, share the project pre-label loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes the last three gaps in the REST/CLI/MCP alignment tracked in #884.
POST /projects/{project_id}/thumbnail-backfill-jobsenqueues anassets.backfill_thumbnailsbackground job (202,Location,BackgroundJobOut). The job result is the same projection the CLI and MCP print. A second launch while a pass for the project is queued or running returns that job. The thumbnail route'sTHUMBNAIL_NOT_CACHEDdocs now point at this route.InferenceConnectionService.resolve; the private_resolveis gone. Tests pin the same error code, message and exit code (text and--json) for an unknown name or id across nine commands.cli/projects.pyandmcp/batches.pysharepre_label_selectioninvisionset.inference.prelabel. Each surface keeps its own progress and output. Refusals still happen before the first forward pass, and neither surface passesreplace_model_labels.Addresses the remaining findings of #884; the tracker is left open for a person to close.
Notes for review
batch pre-labelwith an unknown connection id and a draft or missing batch now reports the connection, which matches MCP and REST. A test pins it.openapi.jsonandfrontend/ui-core/src/generated/are regenerated, not hand-edited.Verification
scripts/check.sh --fast: Python suite 5035 passed; frontend suites,lint-imports(6 contracts kept), the generated-client drift check and the docs gates pass. The OpenAPI drift step failed only while the regenerated file was uncommitted; re-exporting after the commit leaves the tree clean.