Repository navigation
test(app): pin the extraction-grid ordinal convention across the browser/server boundary - #912
Merged
Merged
Conversation
…ser/server boundary (#848)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #848
Adds a cycle test that imports a mid-clip range (0.25–0.5 s at 8 fps) end to end: the real built materializer decodes
vp8.webmin the page, the frames are uploaded to the real server, and the test asserts the first ordinal is nonzero and equalsceil(start x fps)(ordinals[2, 3]), that the storedframe_indexandframe_timestampmatch, and that the source records the range.The test drives the materializer and API directly rather than the range timeline, which only selects whole seconds, while every fixture is 1 s long. No fixture or product change.
Verified by mutation: switching either the browser worker or
VideoProvenance.selectsto selection-relative ordinals fails the test.Checks run:
pnpm --filter @visionset/app cycle video-import(5 passed),pnpm --filter @visionset/app lint.