Skip to content

Add Datenschutzerklärung and Impressum links - #63

Merged
RuslanLomaka merged 2 commits into
masterfrom
claude/datenschutz
Nov 6, 2026
Merged

RuslanLomaka merged 2 commits into
masterfrom
claude/datenschutz

Conversation

@RuslanLomaka

Copy link
Copy Markdown
Owner

Adds a German privacy page for java.ruslanlomaka.org and links to it, plus to the shared Impressum on edv.ruslanlomaka.org, from every page.

This is commit b40fa2a cherry-picked onto the current master. It previously sat on claude/informatics-mail-merge-lesson-le4dri behind two unrelated lesson-kit commits, which is why it never reached the site.

What changes

  • static/datenschutz.html (+ css/legal.css): what the app actually processes, namely Cloudflare delivery, logs without IPs or code, the four GitHub profile fields kept, code that is run and deleted, discussion posts, reactions and re-encoded screenshots (EXIF removed, unused ones purged after 24 h), in-memory rate limits, the session cookie, the sandbox draft in localStorage, GitHub avatars, and the cdnjs/jsDelivr files on the discussion page.
  • SecurityConfig: the page and its stylesheet are public, so logged-out visitors can open it.
  • A shared footer fragment on every signed-in page and a footer on the login page link to Datenschutz and the Impressum. The address is not copied into this repo.
  • CLAUDE.md: the public-paths note now lists the new page.

I re-checked the text against the current code: the localStorage use (the sandbox draft) and the CDN files listed match what the templates load today.

Test plan

  • ./mvnw clean verify locally: Checkstyle clean, 220 tests, 0 failures. New tests cover anonymous access to /datenschutz.html, both footers, and the dev profile.
  • The 28 errors locally are the five Postgres/Testcontainers classes (no Docker in that environment); CI runs them against its Postgres service.

Open item from the tracking doc (D3): the page does not mention database backups. If the PostgreSQL data is backed up, one sentence with interval and retention should be added.

Merging deploys straight to the Pi.


Generated by Claude Code

A static /datenschutz.html (German) describes what the app really
processes: Cloudflare delivery, technical logs without IPs or code,
the GitHub login and the four profile fields kept from it, code that
is run and deleted, public discussion posts, reactions and re-encoded
screenshots (EXIF removed, unused ones purged after 24 h), in-memory
rate limits, the session cookie, the sandbox draft in localStorage,
GitHub avatars and the cdnjs/jsDelivr files on the discussion page.

The page and its stylesheet are public in SecurityConfig. A shared
footer fragment on every signed-in page and a footer on the login page
link to it and to the owner's single Impressum on
edv.ruslanlomaka.org, so the address is not copied into this repo.
Tests cover anonymous access, both footers and the dev profile.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MSe3VqvRc26UaFQN1eDnQY
@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

SonarCloud flagged fragments/footer.html as a page without a <title>
(Web:PageWithoutTitleCheck), which failed the quality gate. Like the
csrf, head and problem-list fragments, it now has a <head> with a title.
Pages include only the footer element, so nothing they render changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017zGVi59QCxQz8QdjGVf6tv
@sonarqubecloud

sonarqubecloud Bot commented Nov 6, 2026

Copy link
Copy Markdown

@RuslanLomaka
RuslanLomaka merged commit 056d984 into master Nov 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants