Repository navigation
feat: type/radius/elevation tokens, resource hints, Latin-only fonts - #1026
Merged
IbrahimIjai merged 2 commits intoOct 21, 2026
Merged
IbrahimIjai merged 2 commits into
IbrahimIjai merged 2 commits into
Conversation
- SO4-Markets#920: replace text-[10px]/text-[11px] with text-10/text-11 tokens and drop the ds-allow comments that excused them. - SO4-Markets#921: replace bare `rounded` with `rounded-sm`, declare --shadow-xs..xl (Tailwind default values, no visual change), document both scales, and make check:tokens reject bare `rounded`. - SO4-Markets#929: replace placeholder example.com dns-prefetch hints with real preconnect (RPC, Horizon) and dns-prefetch (Pyth, Binance) links. - SO4-Markets#930: declare only the Latin face of Geist/Geist Mono/Archivo and preload the Geist face. Built woff2 files: 20 -> 5 (307,132 B -> 120,700 B). Also fixes a broken escape in DepthLadder.test.tsx and two lint errors in segmented-control.tsx that blocked the checks. Commit gate: check:tokens, check:content, test, test:coverage and build pass locally. lint and typecheck FAIL on unrelated pre-existing errors on main (verified identical on a clean main: 11 type errors, web lint errors).
|
@Godbrand0 is attempting to deploy a commit to the Ijai's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Godbrand0 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #920
Closes #921
Closes #929
Closes #930
What changed
text-[10px]/text-[11px]->text-10/text-11tokens; removed theds-allowcomments that excused them.rounded->rounded-sm(same 4px); declared--shadow-xs..xl(Tailwind default values, no visual change);check:tokensnow rejects barerounded;DESIGN.mdand the docs design-system page document the radius and elevation scales.example.comdns-prefetch hints replaced by realpreconnect(RPC, Horizon) anddns-prefetch(Pyth, Binance) links built from env config (resource-hints.ts, with tests).@fontsource-variable/geisttoapps/web(previously undeclared there).Measurements (
bun run build, apps/web)Lighthouse was not run.
Verification — please read
check:tokens,check:content,test,test:coverage,build.lintandtypecheckFAIL, on errors that already exist onmain. I verified on a cleanmain: the same 11tscerrors (e.g. missinguseStateinTVChart.tsx, missingcninTradePanel.tsx, duplicate functions indebug-logger.ts) and web lint errors are present without this change. They are not fixed here.DepthLadder.test.tsx(syntax error that hid all other type errors) and two lint errors insegmented-control.tsx.package.json/bun.lockchange, and the integration-check steps. The changelog entry is also still to come.