Repository navigation
fix(ui): light-theme parity and remove duplicate primitives - #1027
Merged
IbrahimIjai merged 1 commit intoOct 21, 2026
Merged
Conversation
Closes SO4-Markets#922, closes SO4-Markets#917, closes SO4-Markets#916. - SO4-Markets#922: :root lacked the surface-*/text-* roles (and --text-disabled everywhere), so those utilities rendered nothing in light mode. Its subtle/border status tints and --chart-* tokens were dark-tuned, giving near-black badges and a black chart on white. Defined the missing roles, light tints and chart tokens; darkened success/warning/liquidation to >=4.5:1 on white and restored the bright values (plus aliases) in .dark. Synced chart-theme light fallbacks, DESIGN.md and generated token docs. - SO4-Markets#917: removed src/ui/connect-button.tsx, an unused duplicate of features/wallet ConnectButton referenced only by a test. - SO4-Markets#916: removed unused shared Modal, skeleton loaders and toast shim in favour of the @workspace/ui dialog/skeleton/toast. Verified: ui tests, docs tests, build, check:content pass. Baseline main already fails lint, typecheck, check:tokens, changelog:validate and 234 web tests (identical count before/after); not touched here.
|
@Godbrand0 is attempting to deploy a commit to the Ijai's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@gerani1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #922,
closes #917,
closes #916.
ConnectButtonimplementations #917: removed src/ui/connect-button.tsx, an unused duplicate of features/wallet ConnectButton referenced only by a test.packages/ui#916: removed unused shared Modal, skeleton loaders and toast shim in favour of the @workspace/ui dialog/skeleton/toast.Verified: ui tests, docs tests, build, check:content pass. Baseline main already fails lint, typecheck, check:tokens, changelog:validate and 234 web tests (identical count before/after); not touched here.