Repository navigation
refactor(ui): consolidate empty-state primitives - #1030
Merged
Merged
Conversation
Remove `empty.tsx` and make `empty-state.tsx` the single EmptyState primitive. `command-menu` now renders the canonical component, and `states.tsx` re-exports `EmptyState` (keeping a deprecated `action` shorthand) instead of maintaining a second implementation. Closes SO4-Markets#918
|
@Praise14 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@Praise14 is attempting to deploy a commit to the Ijai's projects Team on Vercel. A member of the Team first needs to authorize it. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #918 - Removed the duplicate
empty.tsxprimitive and madeempty-state.tsxthe single canonical EmptyState implementation.states.tsxnow re-exports it (with a deprecatedactionshorthand) andcommand-menuconsumes it directly, so existing app imports keep working.