Skip to content

fix: prevent deadlock when restarting #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SpikeHD wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent deadlock when restarting #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/runtime.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,15 @@ impl<T: UserEvent> RuntimeContext<T> {
}

pub(crate) fn send_message(&self, message: Message<T>) -> Result<()> {
// Exit requests are always queued because inline dispatch from a command handler
// holding the plugin store mutex re-locks it in `on_event_loop_event`, creating
// a deadlock.
if matches!(message, Message::RequestExit(_)) {
self.sender.send(message).map_err(|_| Error::FailedToSendMessage)?;
self.proxy.wake_up();
return Ok(());
}

let message = if self.is_main_thread() {
match handle_main_thread_message(self, message) {
Ok(()) => return Ok(()),
Expand Down