Repository navigation
v4.15.0 - #1476
Merged
Merged
v4.15.0#1476
Conversation
* update version v4.14.0 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * update release notes v4.14.0 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * [SYNPY- 1922] Fix Wki.copy issue (#1459) * renamed method and redid docstring to be more descriptive * fix issue when copying wikis with empty markdowns * added bug fix to nws.md --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* JSONSchema now saves version info when storing * update operatiosn JSONSchema test
…indings (#1468) pip's vendored urllib3, msgpack, and setuptools trigger HIGH CVEs even on the latest pip release. pip is not needed at runtime, so uninstall it after installing synapseclient. Drop the Debian python3-* packages, which target the system Python rather than the image's Python, and run apt-get upgrade to pick up the patched libpcre2.
#1474) * [SYNPY-1941] Preserve data_file_handle_id when file handle is withheld Synapse omits the file handle from the entity bundle when the caller lacks DOWNLOAD permission (e.g. unmet access requirements). _handle_file_entity still called _fill_from_file_handle() with an empty FileHandle, which overwrote the entity's dataFileHandleId with None. This caused File.get() followed by store() (e.g. moving a file) to fail with "Cannot store file". Only copy file handle fields onto the entity when a file handle was returned. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * [SYNPY-1941] Move file handle guard into _fill_from_file_handle `if self.file_handle:` is always true for a FileHandle dataclass instance, so an empty placeholder FileHandle (left when Synapse withholds the file handle due to missing DOWNLOAD permission) overwrote data_file_handle_id, content_type, content_size, and external_url with None. Guard on `file_handle.id` in File and RecordSet `_fill_from_file_handle` so every caller is protected, and revert the now-redundant guard in entity_factory._handle_file_entity. Add RecordSet regression test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * [SYNPY-1941] Revert to guarding in _handle_file_entity Restore the guard in entity_factory._handle_file_entity and revert the _fill_from_file_handle changes in File and RecordSet. _handle_file_entity is the only caller that can pass an empty placeholder FileHandle and it handles both File and RecordSet, so a single guard there is the smaller fix. Keep both File and RecordSet regression tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* updated pandas to use 3.x * fix tests that do not work in pandas 3.x * fix issue with duplicated df indeces * fix nan to none helper * construct_rownames now takes a RowSet * added comments to tests * cast columns to objects * pinned numpy versiosn for specific pandas versions * added unit tests * added helper function * add type hints and unit tests
* updated pandas to use 3.x * fix tests that do not work in pandas 3.x * added support for python3.15 * made arg positional * made arg positional * ran black * fix issue with duplicated df indeces * fix nan to none helper * construct_rownames now takes a RowSet * fix issue with duplicated df indeces * fix nan to none helper * construct_rownames now takes a RowSet * added comments to tests * updated dockerfile * updated pandas to use 3.x * fix tests that do not work in pandas 3.x * fix issue with duplicated df indeces * fix nan to none helper * construct_rownames now takes a RowSet * added comments to tests * cast columns to objects * pinned numpy versiosn for specific pandas versions * added unit tests * added helper function * add type hints and unit tests
* update dependencies * fixed issue with unchecked strings
linglp
approved these changes
Nov 4, 2026
linglp
left a comment
linglp
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Could you look into the test failure and create tickets if they need to be fixed? I was able to install the release candidate with Python 3.15 and retrieved a recordset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v4.15.0. Release candidate: https://github.com/Sage-Bionetworks/synapsePythonClient/releases/tag/v4.15.0-rc
Release notes are in docs/news.md.
🤖 Generated with Claude Code