Conversation
…resolve name clash with built-in python names
…inize repeat files
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
DrPaulSharp
approved these changes
Sep 18, 2026
DrPaulSharp
left a comment
DrPaulSharp
left a comment
Contributor
There was a problem hiding this comment.
All looks good, just a few minor issues to address.
… and moving unique files from trend_test_data into test_file
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…ories into base test_files directory
…evious sub directory to eliminate duplicate data files
There was a problem hiding this comment.
No quality gates enabled for this code.
See analysis details in CodeScene
Quality Gate Profile: Custom Configuration
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
krzywon
added this pull request to stack #238
September 18, 2026 13:53
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a full reorg of the new data importers. I've also better organized the unit tests, including setting all unit test data into a central, importable location, which is why so many files are touched.
Changes:
temp_<type>_reader.pytoimport_<type>.pyWith the number of changes here, especially in the unit tests, I figured I should get this reviewed and merged sooner rather than later. I plan to branch off this point while I continue to work on other issues.
Fixes #128 (Maybe)
Fixes #231
Refs #223
Refs #225
Refs #192