Refactor 24 magnetic metadata - #245
jamescrake-merani wants to merge 9 commits into
Conversation
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
No quality gates enabled for this code.
See analysis details in CodeScene
Quality Gate Profile: Custom Configuration
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
DrPaulSharp
left a comment
DrPaulSharp
left a comment
There was a problem hiding this comment.
This looks good, just one point to consider.
| saturation_magnetization: Quantity[float] | None | ||
| demagnetizing_field: Quantity[float] | None | ||
|
|
||
| def single_line_desc(self): |
There was a problem hiding this comment.
Does this method exist for other metadata classes, and if not, should it be added?
There was a problem hiding this comment.
Is it required alongside summary?
There was a problem hiding this comment.
Yes. Process is one such example. Whether its required, or not is a good question. I only put it there because other classes seem to implement it, but this goes back to the issue I raised in #244 because its not really clear which methods need to be implemented.
This branch has not been deployed
2 participants
Adds data structures for magnetic metadata.