Skip to content

Keep versioned host ABIs out of retired interop detection #821

Description

@wieslawsoltes

Problem

Current main CI run 35507911401 fails the TypeScript profile and bundler tooling gate after the bounded desktop-environment and media-capture ABIs landed.

tooling/webscene/tests/native-binary-interop.test.mjs treats every _v1/_v2 engine symbol outside a hand-maintained allowlist as retired JavaScript invocation interop. The new webscene_engine_set_desktop_environment_v1, webscene_engine_submit_media_capture_packet_v1, and webscene_engine_submit_media_capture_event_v1 entry points are independent, versioned host APIs, so the test reports four false positives (the desktop symbol appears in both declaration and documentation text).

Proposed fix

  • Add the three bounded host APIs to the explicit independent-host ABI inventory.
  • Keep the negative check for retired v1/v2 JavaScript invocation transport symbols.
  • Make the assertion compare unique symbol names so documentation references cannot create duplicate diagnostics.
  • Run the focused Node tooling suite.

Acceptance

  • npm test --prefix tooling/webscene passes.
  • The test still rejects a synthetic or restored retired JavaScript invocation symbol.
  • Current-main CI no longer fails this gate.

Evidence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingvscode-oss/mergedMerged for the AppScene/WebScene VS Code OSS integration

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions