Skip to content

Implement retained CSS caret color - #805

Merged
wieslawsoltes merged 2 commits into
mainfrom
feature/css-caret-color-804
Sep 20, 2026
Merged

wieslawsoltes merged 2 commits into
mainfrom
feature/css-caret-color-804

Conversation

@wieslawsoltes

@wieslawsoltes wieslawsoltes commented Sep 20, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #804.

Unchanged Code OSS authors caret-color: var(--vscode-editorCursor-foreground) on its EditContext textarea, while WebScene painted the retained caret with the text foreground. This change adds generated native/managed caret-color identity and CSSOM, typed color/auto validation, inherited sparse cold-state storage, variable-backed inline resolution, and independent color resolution for the existing kind-14 caret scene command.

It also repairs the inherited-property and mutation-invalidation catalogs for text-wrap and caret-color. The authored gates cover CSSOM inheritance/currentColor/removal/invalid writes, distinct text and caret scene colors, and a 4,096-node paint-only performance guardrail.

Validation: static source review, generated metadata invariant checks, JSON parsing, and git diff --check; focused precompiled JavaScript run 35491228120 passed, and the native document/compiler build and tests passed in step 8 of 35491228122. Local WPT, visual, package, and benchmark execution remains deferred to later qualification.

@wieslawsoltes wieslawsoltes added the vscode-oss/planned Planned for the AppScene/WebScene VS Code OSS integration label Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vscode-oss/planned Planned for the AppScene/WebScene VS Code OSS integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Honor authored caret-color in retained form controls

1 participant