Repository navigation
Release: clock redesign, styles, and CalVer deploys - #24
Merged
Merged
Conversation
Removes the screen name from the app header (Screenly/edge-apps-library#56). Regenerates screenshots to reflect the updated header.
* feat: redesign the clock as a full page display - Replace the photo background with a wash built from the customer accent - Call setupTheme so brand colours reach the app for the first time - Scale the time to roughly two thirds of the canvas, with tabular numerals - Swap Kelly Slab for Inter, already bundled by the SDK - Remove app-header, leaving auto-scaler as the only component in the markup * feat: switch to a light palette for light brand colours - Use isLightColor from the SDK to test the resolved accent colour - Redefine the canvas, ink and rule tokens under a single body class Requires @screenly/edge-apps v1.5.0, which is not published yet. * feat: add a style setting with modern and minimal options - Add a Style select to both manifests, defaulting to traditional - Fall back to traditional for any value the build does not recognise - Drive the type scale from custom properties so each style is one block - Modern is left aligned and heavier, minimal is lighter with a faint wash * chore(deps): bump @screenly/edge-apps to 1.5.0 - Picks up the released isLightColor helper the app already imports
- Use querySelector<HTMLImageElement> to satisfy type-checking
- Add explicit esbuild ^0.28.0 devDependency - Regenerate bun.lock so resolution matches vite's esbuild peer range (^0.27.0 || ^0.28.0)
Render extra landscape and portrait 1080p screenshots pairing each clock style with a locale (de/modern, fr/minimal, es/traditional, ar/traditional) and a matching city, timezone and temperature.
Deploy stage on pushes to main and production on vYY.M.PATCH tags, refusing tags not on the default branch.
There was a problem hiding this comment.
🟡 Changes recommended
Production initialization and tag validation need correction, and the full-page CSS reset should be restored.
4 open findings
What changed in this PR
This PR redesigns the clock with selectable styles, refreshed screenshots and documentation, updated dependencies, and staged/production deployment workflows.
Changes:
- Adds Traditional, Modern, and Minimal clock styles.
- Reworks responsive layouts, settings, weather presentation, and screenshots.
- Routes
maindeployments to stage and CalVer tags to production.
| File | Summary |
|---|---|
src/style.ts |
Resolves supported clock styles. |
src/style.test.ts |
Tests style normalization and fallback behavior. |
src/main.ts |
Initializes styles, themes, clock data, and weather updates. |
src/css/style.css |
Adds responsive style layouts. Moderate (1 vote): restore the body margin and overflow reset. |
screenly.yml |
Adds and reorders settings. Nit (1 vote): document the new style and advanced settings. |
screenly_qc.yml |
Removes the obsolete QC manifest. |
README.md |
Adds release information and preview imagery. Nits: add localized screenshot links, fix the preview path, and document the style setting. |
package.json |
Updates Edge Apps and esbuild dependencies. |
index.html |
Defines the redesigned clock markup. |
e2e/weather-mocks.ts |
Adds reusable localized weather fixtures. |
e2e/screenshots.spec.ts |
Generates localized style screenshot variants. |
bun.lock |
Updates dependency resolution. |
.gitignore |
Ignores generated files and environment data. |
.github/workflows/update-edge-app.yml |
Updates stage and production deployment routing. Moderate (4 votes): enforce the complete CalVer tag format. |
.github/workflows/initialize-edge-app.yml |
Updates app initialization. Critical (4 votes): retain production checkout of main to prevent unreviewed refs from initializing production. |
.github/workflows/checks.yml |
Updates the checks action version. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
514sid
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stylesetting).esbuildfor the vite peer range, typeweatherIconElasHTMLImageElement; bump@screenly/edge-apps.CI/CD
Screenly/edge-apps-actions@v26.10.0.mainnow deploy to stage; pushing a CalVer tag (vYY.M.PATCH, e.g.v26.10.0) deploys to production. Tags not onmainare refused.STAGE_EDGE_APP_ID/PRODUCTION_EDGE_APP_IDrepo variables (theEDGE_APP_IDsecret fallback was removed).