Repository navigation
feat(frontend): surface transaction states and typed errors - #53
Open
woahwhattheheck wants to merge 13 commits into
Open
woahwhattheheck wants to merge 13 commits into
woahwhattheheck wants to merge 13 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44
Summary
PendingTransactionErrorinstead of enabling a blind retry;TRY_AGAIN_LATERresponses retryable, while ambiguous post-broadcast transport failures become status-check-only through the preserved local hash;startWork,submitMilestone, andresubmitMilestone.Scope
Current carrier is intentionally bounded to the frontend acceptance surface in:
src/App.tsxsrc/components/milestone-actions.tsxsrc/components/panel-error-boundary.tsxsrc/lib/web3/contract-service.tssrc/lib/web3/transaction-feedback.tsExact head:
9c967a74e10402b34b68d191fb2e7e450db2f52f(13 commits / 5 files / +570 -121).Current-head acceptance notes
sendTransaction;sendTransactioncall recordspending(localHash)and raisesPendingTransactionError(localHash), so an RPC response loss cannot invite a blind duplicate submission;TRY_AGAIN_LATERremains the explicit retryable send response;ERRORdoes not emit pending; bothPENDINGandDUPLICATEwait for confirmation usingwaitForConfirmation(txHash)at all six milestone gates; non-error returns use the resolvedtxHash;AppLayoutkeys the existingPanelErrorBoundaryby React Router location identity, allowing route B to render after a route-A render fault without requiring a manual Retry first.Validation boundary
Hosted
Build and Testrun37506838167completedaction_requiredon a prior head; that historical run does not validate the current head. No current-head CI-green claim is made. The repository package scripts expose no maintained test runner for the latest one-file transaction-lifecycle repair, so no new test framework or broad verification matrix was introduced. Readback confirms exactly one helper and exactly six issue-facing helper call sites, with the prior direct send/pending blocks removed from those methods. No full-suite, hosted-CI, browser/device, or live-chain green claim is made here.Claim and compensation
This PR continues my existing
/claim #44contribution. I request recognition of my authorship and claim, assignment where required, and payment for this work through the applicable GrantFox bounty process. Please confirm eligibility, the payable amount, and the payment timing. This request preserves the existing claim; it does not assert an award or settlement that has not been confirmed.