Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@
- [ ] `CHANGELOG.md` has an entry in the right section under `[Unreleased]` (added if missing), or the change is not user-visible
- [ ] `.\Tests\Invoke-Tests.ps1` passes
- [ ] Contains no real tenant names, email domains, secrets, or configuration files
- [ ] Any live Microsoft Graph testing was done in a test tenant and is described above
- [ ] Any live Microsoft Graph testing is described above, and sent messages and files only to accounts you control
5 changes: 3 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ Thank you for helping improve ScriptMessage. This guide covers the everyday work
- **Never commit a real configuration file, secret, or certificate.** Never name a real organization, tenant, or
email domain in code, tests, examples, or commit messages; use an RFC 2606 reserved domain instead, such as
`example.com`. Those can never be registered, so a placeholder that gets run unedited reaches nobody.
- **The automated tests never connect to a tenant.** If a change needs a live Microsoft Graph test, run it in
your own test tenant and describe what you tested in the pull request.
- **The automated tests never connect to a tenant.** If a change needs a live Microsoft Graph test, you don't need
a test tenant: any tenant you're allowed to test in will do, as long as every message and file you send goes
only to accounts you control. Describe what you tested in the pull request.
- **Text files are UTF-8 with LF line endings and no byte order mark, and PowerShell files contain only ASCII.**
Windows PowerShell 5.1 misreads non-ASCII characters in PowerShell files saved without a byte order mark.
`.gitattributes` handles line endings, the test suite checks all three rules, and [AGENTS.md](./AGENTS.md)
Expand Down
4 changes: 2 additions & 2 deletions RELEASING.md
Original file line number Diff line number Diff line change
Expand Up @@ -215,5 +215,5 @@ enforceable:
- [ ] The wiki (`Sekers/ScriptMessage.wiki`) describes this release, and its update was pushed after the Release
workflow passed.
- [ ] `main` was merged back into `develop` with a merge commit.
- [ ] Anything that needs a live Microsoft Graph test was tested separately in a test tenant. The automated tests
never connect to a tenant.
- [ ] Anything that needs a live Microsoft Graph test was tested separately, sending messages and files only to
accounts the tester controls. The automated tests never connect to a tenant.
Loading