feat(API): refactor merge http servlets

[SeriousCoding789]

What does this PR do?

Implements tronprotocol#6922.

develop serves the four HTTP surfaces (FULL, SOLIDITY, PBFT, and the standalone SolidityNode) with parallel sets of servlets and four hand-written registration lists. This PR collapses them onto one servlet per endpoint:

• Deletes the 100 per-surface servlets (*OnSolidityServlet, *OnPBFTServlet, http/solidity/*SolidityServlet). 98 of them carry no logic at all — the whole class body is walletOnSolidity.futureGet(() -> super.doGet(req, resp)), i.e. a class per endpoint whose only job is to switch the read cursor.
• Replaces them with a cursor filter (WalletCursorFilter + SolidityCursorFilter / PbftCursorFilter) mounted on /* of the solidity and pbft ports. Switching the cursor is a per-request, thread-level concern; it does not need a subclass per endpoint.
• Replaces the four registration lists with @HttpApi / @HttpApiExcluded declared on the servlet itself, and derives a read-only HttpApiRegistry from them by classpath scan. Adding an endpoint becomes a one-place change instead of a four-place change.
• The registry is validated at startup, before Jetty binds. Duplicate or malformed suffixes, a non-READ endpoint on a cursor surface, a servlet declaring neither annotation or both, an endpoint declared on a nested or abstract class, and a missing @Component all fail the node with TronError(API_SERVER_INIT) instead of silently dropping an endpoint.

356 files changed, +2136 / −4751.

Why are these changes required?

Duplicating an endpoint across surfaces is not free — it drifts silently, and two live examples on develop came out of this work:

• The standalone SolidityNode's own copy of gettransactioninfobyid never picked up the visible=true → convertLogAddressToTronAddress step the base servlet has, so it returns log[].address in hex where FullNode returns base58.
• The PBFT registration list has been out of step with the other three surfaces for years: 5 sapling endpoints that were taken off FULL/SOLIDITY in 2020 stayed active on PBFT, and 2 read endpoints the other three surfaces expose were never mounted there.

Both are "change one place, forget the other" bugs. With one servlet per endpoint and a derived registry, a surface can no longer fall behind on its own.

Behaviour differences vs develop

Every per-surface servlet was classified by whether its body contains futureGet: 98 pure cursor delegations (cannot drift) and 2 hand-copied implementations (can). Per-surface result:

Surface	Per-endpoint logic	Endpoint set
FULL	unchanged	120 → 120, no change
SOLIDITY	equivalent (delegation → filter)	44 → 44, no change
SOLIDITY_NODE	2 endpoints differ, see below	44 → 44, no change
PBFT	equivalent (delegation → filter)	47 → 44, −5 / +2

Client-visible changes, all deliberate and worth a release note:

1. Standalone SolidityNode /walletsolidity/gettransactioninfobyid — with visible=true on a transaction that has logs, log[].address changes from hex to Tron base58, matching FullNode. This is the drift fix above; visible=false and log-free transactions are unaffected.
2. PBFT port drops 5 sapling endpoints — getmerkletreevoucherinfo, isspend, scanandmarknotebyivk, scannotebyivk, scannotebyovk now return 404 on /walletpbft/*. They were disabled on every other surface in 2020; PBFT is catching up, not regressing.
3. PBFT port gains 2 read endpoints — getpaginatednowwitnesslist and gettransactioninfobyblocknum, which FULL / SOLIDITY / SolidityNode already expose. Pure addition.

Error responses on the two former SolidityNode copies now go through Util.processError (the standard {"Error": ...} body) instead of writing the raw exception message into the response.

This PR has been tested by:

• Unit Tests — 24 new tests, all passing:

  • HttpApiRegistryTest (17). Twelve drive one validation branch each through a fixture package under http/regtest/* and assert the boot failure it produces: a servlet declaring neither annotation or both, an endpoint on a nested or abstract class, a duplicate (surface, suffix), a blank suffix, a / in a suffix, a * or whitespace suffix, a missing @Component, an empty surface list, and a non-READ endpoint on a cursor surface. One builds a valid fixture package. The remaining four are the mount-parity tests: each service's mounted path set equals the registry's derived set for its surface, so an endpoint cannot be declared and left unmounted, or mounted without being declared.
  • CursorFilterInstallationTest (4) runs each service's real addFilter and asserts solidity and pbft install exactly one cursor filter on /*, while the FULL port and the standalone SolidityNode install none — a cursor filter on either of those would take the port off HEAD.
  • WalletCursorFilterTest (3) asserts the cursor is set before chain.doFilter and reset in finally including when the servlet throws, and that the PBFT subclass switches to the PBFT cursor rather than SOLIDITY.

  There is no frozen route snapshot: the registry is validated in full when the class is first touched — before Jetty binds, and for every surface whether or not the node enables it — so the invariants are enforced at boot and the tests drive the failure paths rather than re-asserting them over the live table.

• Manual Testing — brought up a private chain and checked the mounted endpoint set on every port, including that endpoints marked @HttpApiExcluded are unreachable.

Follow up

• Grouping the servlet package by function, as raised in the issue discussion. Kept out of this PR so the diff stays a mechanical de-duplication and the endpoint set remains directly diffable; worth doing once this lands.
• Publishing the per-endpoint inventory and the PBFT surface changelog alongside the release note.

Extra details

@HttpApi / @HttpApiExcluded are deliberately not @Inherited, and the registry reads them with getDeclaredAnnotation only. Inheritable exposure is exactly what produced the 100 wrapper classes this PR removes — a subclass must never silently inherit its parent's surface set.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: aa895a7d-1c64-4d87-abee-ffc125e2626e

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[warku123]

[MUST] The rate limiter is keyed by the servlet class name, so all surfaces now share one limiter instance.

Before this PR each surface had its own wrapper servlet class (e.g. GetAccountOnSolidityServlet, GetAccountOnPBFTServlet), so the http_<class> keys were distinct and every port had its own permit pool. After the merge, a single GetAccountServlet bean is mounted on /wallet, /walletsolidity and /walletpbft — the same simple name resolves to the same RateLimiterContainer entry, giving one shared QPS budget across three ports. Total capacity drops from 3×qps to 1×qps.

Also, existing rate.limiter.httpMap entries referencing the old *OnSolidity / *OnPBFT class names no longer match anything and are silently ignored (addRateContainer falls back to the default adapter).

Suggestion: key the limiter by surface + suffix (or request context path), and/or document the httpMap key migration in the PR.