Conversation
pior
marked this pull request as ready for review
September 25, 2026 09:05
NewServer built an http.Server with no timeout fields. The Go zero value means no limit, so a client that sends incomplete headers can hold a connection open forever (Slowloris, CWE-400). Set ReadHeaderTimeout to 5s and IdleTimeout to 120s. Callers that need other values can use NewServerFromFactory.
pior
force-pushed
the
srvutil-timeouts-87036
branch
from
September 25, 2026 09:07
6a5a52f to
afdde87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
srvutil.NewServerbuilds anhttp.Serverwith onlyAddrandHandler. The Go zero value for the timeout fields means "no limit".A client can send incomplete headers and keep the connection and its goroutine forever (Slowloris, CWE-400). Many such clients can use up the connections of the server.
Changes
NewServersetsReadHeaderTimeoutto 5s. This closes connections that do not finish the headers in time.NewServersetsIdleTimeoutto 120s. This closes idle keep-alive connections.ReadTimeoutandWriteTimeoutstay unset. They also limit the request body and the handler, so they can break slow uploads or long responses of current callers.NewServerFromFactorycallers to set at leastReadHeaderTimeout.//nolint:gosecsuppression is removed, because gosec now accepts the literal.