Repository navigation
Pull ubuntu from ECR and log in to Docker Hub when a token exists - #138
Merged
Merged
Conversation
…when a token exists, so its anonymous pull limit stops failing CI
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Singtaa/OneJSv3Container#14. ubuntu:22.04 comes from public.ecr.aws/docker/library, which has no anonymous pull limit. unityci/editor has no public mirror, so a Docker Hub login step runs once DOCKERHUB_USERNAME and DOCKERHUB_TOKEN exist, and is skipped until then.