Skip to content

docs: require Codex review and resolved threads before merge - #5644

Merged
Sinity merged 2 commits into
masterfrom
ci/codex-review-gate
Sep 27, 2026
Merged

Sinity merged 2 commits into
masterfrom
ci/codex-review-gate

Conversation

@Sinity

@Sinity Sinity commented Sep 27, 2026 •

Copy link
Copy Markdown
Owner

Summary

Documents the merge requirements: a completed Codex review of the exact head (the codex-review status), resolved review threads, and queued squash merges.

Problem

Codex reviews every PR but publishes no status, so a PR could merge on a green quick gate before Codex finished or with unanswered findings.

Solution

  • CONTRIBUTING lists the steps and the protected-branch settings: ci/circleci: quick-gate and codex-review required, conversation resolution required, codex-review-waived label as an explicit override.
  • The status itself is published by a host service outside this repository (GitHub Actions is unavailable on the account), so no workflow is added here.

Verification

  • Documentation only; the rendered steps were read back.

🤖 Generated with Claude Code

https://claude.ai/code/session_013Vn4qhKjhyaVBG4aPiqNW4

Publish a codex-review commit status from the Codex summary comment so
branch protection can require it, and document the merge requirements.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013Vn4qhKjhyaVBG4aPiqNW4
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-27T17:58:37.454886Z bf5225e New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 94124a9d82

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/codex-review-gate.yml Outdated
Comment thread .github/workflows/codex-review-gate.yml Outdated
GitHub Actions cannot run on this account, so the status is published
outside the repository; keep only the documented merge requirements.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013Vn4qhKjhyaVBG4aPiqNW4
@Sinity Sinity changed the title ci: require a completed Codex review of the exact PR head docs: require Codex review and resolved threads before merge Sep 27, 2026
@Sinity
Sinity enabled auto-merge (squash) September 27, 2026 17:59
@Sinity
Sinity merged commit b205258 into master Sep 27, 2026
3 checks passed
@Sinity
Sinity deleted the ci/codex-review-gate branch September 27, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant