Repository navigation
ci: retire the CircleCI stacked-review-threads job - #5777
Merged
Merged
Conversation
The stacked-review-threads status is now posted by the Sinnix status timer with gh's persistent login, every two minutes, so the CircleCI job, its devtools module, and its tests leave with it: one authority for the gate, and none that needs a CI secret. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015pdKaZWyGe6Ngvsz468dzg
Sinity
enabled auto-merge (squash)
September 29, 2026 00:13
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the CircleCI
stacked-review-threadsjob,devtools/stacked_review_threads.py, and its tests. Thestacked-review-threadscommit status is now posted by a Sinnix user timer (stacked-review-threads-status, Sinity/sinnix 49d11e9b), next to the existingcodex-reviewstatus pass.Problem
The job, added in #5740, failed on every PR with "no GitHub token". The CircleCI project has no
GH_TOKEN, and nobody can administer that project from this login. The job also re-ran only on push, so resolving a thread left the result stale until the next commit.Solution
The Sinnix pass authenticates with gh's persistent login and runs every two minutes over every open PR targeting master. It keeps the semantics of the deleted module. Every PR merged into the head branch counts. The walk recurses into each stacked PR's head branch, bounded by that PR's merge time. Expansion is keyed per PR, so each lifetime of a reused branch name gets its own bound. The walk is cycle-safe and follows pagination on merged PRs and threads.
It fails closed: a read error sets
pending, neversuccess. It writes a status only when the state changes. Reads are aliased per stack level, so a head with nothing merged into it costs no query of its own. With two authorities for one gate, one would be dead weight, so this PR deletes the CircleCI copy.Verification
nix develop --command devtools verify --quick:verify: PASSED exit=0(all 12 static gates ok).git grep -n "stacked_review_threads\|stacked-review-threads"on this branch: no matches.stacked-review-threads: successon the open heads, for example fix(intake): one interpretation across live and retained routes #5643 (1 stacked PR has no unresolved review threads).Residuals
stacked-review-threadsbecomes a required master context after this merges. Until then it is advisory.🤖 Generated with Claude Code
https://claude.ai/code/session_015pdKaZWyGe6Ngvsz468dzg