fix(dedup): deterministic collision merges and fold report - #194
Merged
Merged
Conversation
uuid_on_collision=merge previously kept first-seen scalar values, so source ordering changed shipped edges and silently selected conflicting attributes. Choose lexicographically smallest canonical scalar value instead, preserving list unions and exact number_of_cases semantics. Emit per-predicate, per-field conflict counts beside merged NDJSON for downstream drift review. Extend Rust fuzz oracle and regression coverage.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SkyeAv
added a commit
that referenced
this pull request
Sep 21, 2026
Cut 19.2.0 and bump package version in pyproject.toml, CITATION.cff, and uv.lock. Minor: add configurable QC cascade thresholds and aliases, separator-aware matching, token-set fallback, deterministic collision scalar winners, and fold conflict reports (#194, #195). Changelog: - Versioned 19.2.0 section with entries for #194 and #195. Docs: Updated in merged PR #195. Testing: - uv run pytest -q --no-cov -> 1651 passed, 52 skipped, 3226 warnings in 36.49s - uv run ruff check . -> pass - uv run ruff format --check . -> pass - uv run pyright -> 0 errors, 0 warnings, 0 informations - uv lock --check -> pass - cargo fmt --check --manifest-path rust/Cargo.toml -> pass - cargo clippy --manifest-path rust/Cargo.toml --all-targets -- -D warnings -> pass - cargo test --manifest-path rust/Cargo.toml -> pass - uv run --no-sync mkdocs build --strict -> pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Stacked on