Repository navigation
fix: webhook timeouts, API key scoping, query optimization, and error localization - #596
Merged
ritaifeoluwa merged 4 commits intoOct 19, 2026
Conversation
Enforces 'airdrops' scope requirement on all POST, PATCH, and DELETE airdrop endpoints to prevent over-privileged API keys from performing sensitive operations. Resolves SmartDropLabs#569
Creates composite indexes on frequently queried column combinations to improve query performance and reduce database load during filtering and sorting operations. Resolves SmartDropLabs#570
Implements i18n service for error messages with support for English, Spanish, and French. Error responses are automatically localized based on the Accept-Language header. Resolves SmartDropLabs#571
|
@fortezzalaboratory Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes four critical issues: webhook timeout handling, API key scoping, database query optimization, and error message localization.
Issues Resolved
Closes #568
Closes #569
Closes #570
Closes #571
Changes
#568 - Webhook timeout not handled
Enhanced webhook delivery error handling to distinguish timeout errors (ETIMEDOUT) from other network errors, enabling better logging and metrics tracking for timeout-specific issues.
#569 - No API key scoping
Added API key scope requirements to all airdrop mutation endpoints (POST /airdrops, PATCH, DELETE, /cancel, /recipients) to prevent over-privileged API keys from performing sensitive operations.
#570 - No query optimization
Added composite database indexes for common query patterns:
These improve query performance for filtering and sorting operations.
#571 - Error responses not localized
Implemented i18n service supporting error message localization for English, Spanish, and French. Error responses automatically localize based on Accept-Language header.