Repository navigation
fix: cascade-delete, query streaming, API version negotiation, data access audit (#559-#563) - #598
Merged
Conversation
…tiation, data access audit - SmartDropLabs#559: webhookRepository.remove() now cascade-deletes associated delivery records, retry-queue entries, and per-status indexes - SmartDropLabs#560: add streamQuery() and streamBatches() to database module for large result sets without loading everything into memory - SmartDropLabs#562: add Accept-header version negotiation middleware (application/vnd.smartdrop.vN+json) with X-API-Version response header - SmartDropLabs#563: add DataAccessAuditor middleware logging data reads/writes with actor, resource, endpoint, and result
|
@pooramara Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #559
Fixes #560
Fixes #562
Fixes #563
What changed
webhookRepository.remove()now cascade-deletes associated delivery records, retry-queue entries, and per-status indexes — no more orphaned data.streamQuery()andstreamBatches()to the database module for iterating large result sets without loading everything into memory.application/vnd.smartdrop.vN+json) withX-API-Versionresponse header. Unsupported versions return 406.DataAccessAuditormiddleware that logs every data read/write with actor, resource, endpoint, IP, and result for compliance and breach detection.Why
How to test
streamBatches()on a large table — memory stays flat.Accept: application/vnd.smartdrop.v1+json— response includesX-API-Version: v1.Accept: application/vnd.smartdrop.v99+json— returns 406.[DATA_ACCESS]entries after API reads.