Repository navigation
feat(payments): add payment link generation with configurable expiry - #1873
Merged
github-actions[bot] merged 1 commit intoOct 21, 2026
Merged
github-actions[bot] merged 1 commit into
github-actions[bot] merged 1 commit into
Conversation
|
@JohnMabas Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements signed, expirable payment links with revoke capability for merchants, closing #1713.
Merchants need shareable payment links that stop working after a set time. This PR introduces a
PaymentLinkServicethat generates HMAC-SHA256 signed, unguessable links and lets merchants revoke them at any time.What was built
backend/services/payment/domain/paymentLinkService.tsPaymentLinkService— core service with injectable store and clock for full testabilityid + merchantId + amount + currency + expiresAtusing a per-merchantsigningSecret; tokens cannot be guessed or forgedMerchantPaymentLinkConfig.defaultExpirySecondssets the default TTL; callers can also supply a customexpirySecondsper linkrevokeLink(id)stampsrevokedAtand setsstatus = 'revoked'; subsequentvalidateLinkcalls reject withreason: 'revoked'validateLink(id, token)returns a typedValidationResult— callers never need to catch exceptions for expected failure casescreateLink/getLink/listLinksround out the APIPaymentLinkStoreinterface +InMemoryPaymentLinkStorefor easy swap to a DB-backed storebackend/services/payment/__tests__/paymentLinkService.test.tsAcceptance criteria
validateLinkreturns{ valid: false, reason: 'revoked' })Testing
All 37 tests pass.
Closes #1713