Repository navigation
feat(stellar): add multi-signature approval for charges above a threshold - #1875
Merged
github-actions[bot] merged 1 commit intoOct 21, 2026
Merged
Conversation
|
@JohnMabas Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements M-of-N multi-signature approval for high-value charges, closing #1715.
High-value charges currently execute from a single key. This PR requires M-of-N approval from authorized signers before a charge above a configurable per-merchant threshold can proceed.
What was built
backend/services/stellar/multiSigApprovalService.tsMultiSigApprovalService— orchestrates the approval workflow; all dependencies injectable for full testabilityMerchantMultiSigConfigcarriesthresholdAmount,currency,requiredApprovals(M),totalSigners(N), andsignerAddresses; charges below the threshold returnnullimmediately (no approval needed)getApprovalStatus(requestId)returns the fullMultiSigApprovalRequestwithapprovals,rejections,status, andresolvedAtpending, second approval transitions toapproved)status = 'rejected'immediatelyexpireStaleRequests(now)marks pending requests whoseexpiresAthas passed asexpiredApprovalResulterrors — no exceptions thrownMultiSigStoreinterface +InMemoryMultiSigStorebackend/services/stellar/__tests__/multiSigApprovalService.test.tsisChargeApproved(approved / pending / below-threshold), expiry sweep, and approval on expired requestAcceptance criteria
MerchantMultiSigConfig.thresholdAmountscoped tomerchantId)getApprovalStatusreturns full request state includingapprovals,status)Testing
All 20 tests pass.
Closes #1715