Repository navigation
chore(ci): bump Go toolchain to 1.26 - #17
Merged
Merged
Conversation
Go 1.22 is EOL. The toolchain version now lives only in mise.toml since the mise migration, so this is a one-line change. Deliberately NOT touching the `go` directive in go.mod — that declares the minimum language version for consumers of the published module, and raising it would be a breaking change for them. Verified: go build/vet/test and gofmt all pass on 1.26. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Go toolchain is pinned to 1.22, which is end-of-life — it no longer receives security or bug fixes. CI has been building and testing the
go/module on an unsupported toolchain.Change
One line in
mise.toml:Since the mise migration, the Go version lives only in
mise.toml—jdx/mise-action@v4reads it in bothpr-checks.ymlandrelease.yml, and there is noactions/setup-goorgo-versionanywhere in.github/. So this single line is the whole change. mise resolves1.26to go1.26.7.Deliberately NOT changing
go.modgo/go.modstill declaresgo 1.22.0, and that is intentional. That directive is the minimum language version required of consumers of the publishedgithub.com/SmooAI/audit/gomodule — raising it to 1.26 would be a breaking change for anyone importing us on an older Go. What we are bumping here is only the toolchain we build and test with. The two are independent, and building ago 1.22.0module with a 1.26 toolchain is fully supported.Worth noting: Go can silently append a
toolchaindirective togo.modduring a build. It did not here — the diff is verifiably one line.Verification
Run locally against mise's
go1.26.7(mise exec, not the ambient Homebrew go), using the repo's own scripts — the same ones CI invokes:pnpm go:fmt:check(gofmt -l .)pnpm go:lint(go vet ./...)pnpm go:build(go build ./...)pnpm go:test(go test -count=1 -v ./...)ok github.com/SmooAI/audit/go 0.298soxfmt --check .mise.tomlThe full Go suite is green: the 8-scenario
TestParityCorpus,TestComputeEventHashMatchesCorpus, the 11-caseTestChainCorpus(tamper/reorder/truncation detection), and the emit/retry and trace-context tests.Nothing broke on the 1.22 → 1.26 jump. That is a four-version leap, so genuine incompatibilities were plausible, but the
go/module is small and depends only ongo.opentelemetry.io/otel/trace— no build, vet, or test regressions surfaced.The
oxfmt --checkrun is called out explicitly because a previous PR was reddened by oxfmt reformatting.tomlfiles,mise.tomlincluded. It is clean here —go = "1.26"is the same token shape asgo = "1.22".