Repository navigation
fix(cc): make every Lua method final - #34
Merged
Merged
Conversation
ComputerCraft logs "Lua Method ... should be final" for each overridable @LuaFunction the first time a computer uses a peripheral. 62 methods across nine Simulated peripherals were missing final. No behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ComputerCraft logs
Lua Method ... should be finalfor each overridable@LuaFunctionthe first time a computer uses a peripheral. Showed up while testing the controller bridge; it's been there since before. 62 methods across nine Simulated peripherals (altitude sensor, navigation table, gimbal sensor, velocity sensor, torsion spring, portable engine, physics assembler, steering wheel, analog transmission) are nowfinal. No behaviour change; build and tests pass.