Skip to content

fix: don't copy line numbers when copying a section of the log #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ozgesolidkey merged 1 commit into from
Aug 13, 2026
Merged

fix: don't copy line numbers when copying a section of the log #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/renderer/renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1635,7 +1635,7 @@ function secondaryRenderVisibleLines(sv: SecondaryViewerInstance): void {
div.className = className;
div.dataset.lineNumber = String(line.lineNumber);

const lineNumHtml = `<span class="line-number">${line.lineNumber + 1}</span>`;
const lineNumHtml = `<span class="line-number" data-lineno="${line.lineNumber + 1}"></span>`;
const contentHtml = `<span class="line-content">${escapeHtml(line.text)}</span>`;
div.innerHTML = lineNumHtml + contentHtml;

Expand Down Expand Up @@ -2927,7 +2927,7 @@ function createLineElementPooled(line: LogLine): HTMLDivElement {
if (isLineMuted(line.text)) div.classList.add('muted');

// Create content using innerHTML for speed (single parse)
const lineNumHtml = `<span class="line-number">${line.lineNumber + 1}</span>`;
const lineNumHtml = `<span class="line-number" data-lineno="${line.lineNumber + 1}"></span>`;
let displayText = applyColumnFilter(line.text);

// Truncate very long lines to prevent DOM/rendering slowness
Expand Down Expand Up @@ -2994,7 +2994,7 @@ function createPlaceholderLinePooled(displayIndex: number): HTMLDivElement {
div.dataset.lineNumber = '';
const numHtml = state.isFiltered
? '<span class="line-number"></span>'
: `<span class="line-number">${displayIndex + 1}</span>`;
: `<span class="line-number" data-lineno="${displayIndex + 1}"></span>`;
// Dim inline bar (currentColor adapts to the theme); width jittered by index so
// the skeleton reads as text, not a solid block.
const barWidth = 30 + (displayIndex % 7) * 8; // 30–78%
Expand Down Expand Up @@ -3032,7 +3032,9 @@ function createLineElement(line: LogLine): HTMLDivElement {

const lineNumSpan = document.createElement('span');
lineNumSpan.className = 'line-number';
lineNumSpan.textContent = String(line.lineNumber + 1);
// Render the number via CSS ::before (data-lineno) so it's NOT real DOM text and can't
// be selected/copied — copying a section yields the log text only, no line numbers.
lineNumSpan.setAttribute('data-lineno', String(line.lineNumber + 1));

const contentSpan = document.createElement('span');
contentSpan.className = 'line-content';
Expand Down
8 changes: 8 additions & 0 deletions src/renderer/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2668,11 +2668,19 @@ button.is-cancelable:hover, .btn.is-cancelable:hover { filter: brightness(1.12);
color: var(--text-muted);
text-align: right;
padding-right: 15px;
-webkit-user-select: none;
user-select: none;
border-right: 1px solid var(--border-color);
margin-right: 10px;
}

/* Show the number as CSS-generated content (data-lineno) rather than real text, so
selecting/copying a section of the log NEVER includes the line numbers. Uses ::after
so it doesn't collide with the diff view's ::before +/-/~ gutter markers below. */
.line-number::after {
content: attr(data-lineno);
}

.line-content {
flex: 1;
user-select: text;
Expand Down
Loading