Skip to content

fix: update parseDefaultValue and defaultValueInitializer to handle b… #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oswald-logicLoop merged 1 commit into from
Sep 19, 2026
+19 −15
Merged

fix: update parseDefaultValue and defaultValueInitializer to handle b… #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/code-builder/lib/field/field-managers/boolean/BooleanFieldManagerForDto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,17 +57,19 @@ export class BooleanFieldManagerForDto
};
}

protected override parseDefaultValue(defaultValue: string): boolean | null {
try {
return defaultValue === 'true' ? true : false;
}
catch (e) {
// console.log(`Could not set default value ${defaultValue} for field ${this.field.name} in model ${this.modelName}`);
protected override parseDefaultValue(defaultValue: boolean | string | null | undefined): boolean | null {
if (typeof defaultValue === 'boolean') return defaultValue;

if (typeof defaultValue === 'string') {
const normalizedDefaultValue = defaultValue.trim().toLowerCase();
if (normalizedDefaultValue === 'true') return true;
if (normalizedDefaultValue === 'false') return false;
}

return null;
}

protected override defaultValueInitializer(defaultValueConfig: string): DefaultValueInitializer | null {
protected override defaultValueInitializer(defaultValueConfig: boolean | string | null | undefined): DefaultValueInitializer | null {
const defaultValue = this.parseDefaultValue(defaultValueConfig) ?? false;
return {
value : defaultValue,
Expand Down
18 changes: 10 additions & 8 deletions src/code-builder/lib/field/field-managers/boolean/BooleanFieldManagerForEntity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,22 +33,24 @@ export class BooleanFieldManagerForEntity
return options;
}

protected override parseDefaultValue(defaultValue: string): boolean | null {
try {
return defaultValue === 'true' ? true : false;
}
catch (e) {
// console.log(`Could not set default value ${defaultValue} for field ${this.field.name} in model ${this.modelName}`);
protected override parseDefaultValue(defaultValue: boolean | string | null | undefined): boolean | null {
if (typeof defaultValue === 'boolean') return defaultValue;

if (typeof defaultValue === 'string') {
const normalizedDefaultValue = defaultValue.trim().toLowerCase();
if (normalizedDefaultValue === 'true') return true;
if (normalizedDefaultValue === 'false') return false;
}

return null;
}

protected override defaultValueInitializer(defaultValueConfig: string): DefaultValueInitializer | null {
protected override defaultValueInitializer(defaultValueConfig: boolean | string | null | undefined): DefaultValueInitializer | null {
const defaultValue = this.parseDefaultValue(defaultValueConfig) ?? false;
return {
value: defaultValue,
text: defaultValue.toString(),
expression: defaultValue ? ts.factory.createTrue() : ts.factory.createFalse()
};
}
}
}