Repository navigation
fix(core): resolve issues #844, #849, #852, and #853 - #879
Closed
thatElisha wants to merge 1 commit into
Closed
thatElisha wants to merge 1 commit into
thatElisha wants to merge 1 commit into
Conversation
…orokit#853 - fix(integration): add price oracle staleness validation and threshold checks (Sorokit#844) - fix(shared): provide actionable recovery suggestions for SourceAccountNotFound (Sorokit#849) - feat(soroban): add hit, miss, eviction, and memory tracking to LedgerEntryCache (Sorokit#852) - feat(account): add minimum balance reserve calculation and minReserveAlert rule (Sorokit#853)
|
@thatElisha Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #844
Closes #849
Closes #852
Closes #853
Summary of Changes
This pull request resolves issues #844, #849, #852, and #853 across integration, error handling, Soroban caching, and account reserve alerting.
1. #844 PriceOracle integration: Stale Price Feed Detection
Dateobjects, and ISO date strings.stalenessThresholdMs(defaults to 5 minutes / 300,000 ms).reject(returns a structuredSERVICE_UNAVAILABLEerror result) orwarn(triggers warning callback / logs while allowing degraded execution).2. #849 SourceAccountNotFound: Actionable Recovery Guidance
SOURCE_ACCOUNT_NOT_FOUNDtoSorokitErrorCode.suggestions?: string[]to bothRecoveryGuidanceandSorokitErrorin response.ts.3. #852 LedgerEntryCache: Hit, Miss, Eviction, and Memory Statistics
LedgerEntryCachestored frequently queried entries without recording cache hit rates, eviction events, or memory usage, making cache tuning and monitoring impossible.getStats()exporting:hits: Successful cache hitsmisses: Cache misses (missing or expired entries)evictions: Entries evicted due to LRU capacity limits or TTL expirationmemoryUsed: Approximate memory used in bytes (keys + values)hitRate: Ratiohits / (hits + misses)size: Active entry countcapacity: Maximum entries capacityresetStats()to allow resetting counters for benchmarking without purging active cache entries.4. #853 BalanceAlertRule: Minimum Balance Reserve Tracking
where subentries include trustlines, offers, additional signers, and data entries.
"min_reserve"condition toBalanceAlertConditionandBalanceAlertRule.bufferXlm/threshold).minimumReserve,minimumReserveStroops, andisSubReserve: booleanto emitted alerts.Linked Issues
Closes #844
Closes #849
Closes #852
Closes #853