Repository navigation
fix: resolve integer division truncation and bounds validation issues… - #1056
Closed
edwarddavid929-png wants to merge 1 commit into
Closed
edwarddavid929-png wants to merge 1 commit into
edwarddavid929-png wants to merge 1 commit into
Conversation
…tellar-split#230-Stellar-split#233 - Fix effective_rate_bps calculation to use proper floating-point division to prevent truncation - Add bounds validation to set_global_payer_limit to ensure window_secs is within valid range - Add bounds validation to set_cancellation_cooldown to prevent overflow on u64 values - Add bounds validation to set_archive_after_ledgers to prevent overflow on u64 values Prevents silent truncation of integer division results and enforces type bounds on configuration parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… #230-#233
Prevents silent truncation of integer division results and enforces type bounds on configuration parameters.
Closes #230
Closes #231
Closes #232
Closes #233