Repository navigation
test(remote): wait for B's own link before testing the pairing limit after a reconnect - #95
Merged
Merged
Conversation
…after a reconnect The v1.7.0 release run failed on Linux: A saw B again before B's link had reconnected, so the pairing request could end for another reason than the limit. The test now waits for B's link too, and prints the event it got.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.7.0 release workflow failed on Linux in
reconnecting_does_not_reset_the_pairing_limit(it passed on the PR). A could see B again in the roster before B's own relay link was back, so the pairing request could end for another reason thanbusy. The test now also waits for B's link, and the assertion prints the event it got. Test-only.