Conversation
The published analysis saved a density plot of the average abundance of the candidate ribosomal subunits; the Python version now writes it, with the numbers behind it, from the ribosome step.
The two enzyme-usage figures and the ribosomal subunit abundance figure, from a full run of the analysis on the ecModels gecko4 model with --fit-rates.
The usage figures follow boxplotEnzymeUsage.R (theme_classic, 7 pt text, 10 x 4.5 cm, the published panel colours, unfilled boxes with a doubled median, solid outliers), and the subunit figure is the default MATLAB density plot with its axes, fonts and title. A subunit missing from a replicate has no average, as in MATLAB's mean, which also brings the plotted range back to the published one; the selected core is unchanged.
From a full run of the analysis with --block r_2129: the respiration is coupled, so the TCA cycle and ETC panels change at the high C/N conditions.
The tables of a full run of the analysis (ecModels gecko4 model, --fit-rates, proton leak closed): enzyme usage, model generation, the fluxes of each condition, the sampling tables and the comparison with the published results. The models are not committed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published analysis saved a density plot of the average abundance of the candidate
ribosomal subunits (
average_riboSubunit_abundance.pdf). The Python version did notwrite it. It is the only saved figure that was missing; the two enzyme-usage figures
already exist.
python -m overflow.build_ribosomenow also writesresults/modelGeneration/average_riboSubunit_abundance.pdfand the numbers behind it,averageRiboSubunitAbundance.tsv.abundance over every replicate of every condition, with MATLAB's default axes, fonts and
title. A subunit missing from any replicate has no average, as in MATLAB's
mean(157 of the 177 measured candidates), which also brings the range back to the
published -7.3 to -3.9. The selected core is unchanged (48).
candidate_meansgives the averages for every measured candidate;core_subunitsselects exactly as before.
Tests: the density integrates to one and peaks where the data do, the figure reports
the core count and is written, and on the real data the plotted means agree with the
selected core. 196 tests pass on Gurobi.
All three figures are drawn as the published ones: the usage figures follow
boxplotEnzymeUsage.R(theme_classic, 7 pt text, 10 x 4.5 cm, the published panel colours,unfilled boxes with a doubled median line, solid outlier points) and the subunit figure is
MATLAB's default density plot. Helvetica is used where installed, else the metric-compatible
Nimbus Sans. They are included under
results/from a full run of the analysis (ecModelsgecko4 model,
--fit-rates, proton leak closed with--block r_2129):enzymeUsage/selectedSystemUsage.pdf,enzymeUsage/supplementSystemUsage.pdfandmodelGeneration/average_riboSubunit_abundance.pdf.The tables of that run are committed too, as the published repo did with its results: the
enzyme-usage tables, the model-generation tables,
allFluxes_<cond>.tsvfor each condition,the sampling tables and
COMPARISON.md, all underresults/. The built models(
models/ecModel_P_<cond>.yml, about 67 MB) are not committed and rebuild in a fewminutes with the README recipe.