Skip to content

Align Artifact Mine defaults with production - #24

Merged
XxFran10xX merged 2 commits into
mainfrom
followup/sealed-artifact-alignment
Oct 21, 2026
Merged

XxFran10xX merged 2 commits into
mainfrom
followup/sealed-artifact-alignment

Conversation

@XxFran10xX

@XxFran10xX XxFran10xX commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Fresh installations shipped an older Artifact Recovery definition than Main and Dev. Align artifact_focus with the existing production Artifact Mine: menu weight 1, matching name and icon, upkeep 20, and Common/Uncommon/Rare/Legendary weights 65/25/7/3.

Existing configuration files are preserved, so upgrading the jar does not rebalance existing nodes or overwrite server settings. No Java behavior changes.

Validation: all 236 tests pass in Linux CI. All 26 focused Windows configuration/lifecycle tests pass; the full Windows suite has eight file-persistence failures reproduced unchanged on origin/main. Dev passed a 54-check integration smoke test covering the bundled defaults and icon, all four artifact outputs delivered into a hopper, recycling returns/husks, and rejection of unopened seals. Self-review completed within three rounds with no remaining findings.

Documentation: TF-Minecraft/Docs#312

@github-actions github-actions Bot added the size:S 10-29 effective changed lines (tests excluded in mixed PRs). label Oct 21, 2026
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 17063460-5ebd-48e2-85fd-a624db1f026b
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@XxFran10xX
XxFran10xX marked this pull request as ready for review October 21, 2026 17:06
@XxFran10xX
XxFran10xX merged commit cfab588 into main Oct 21, 2026
4 checks passed
@XxFran10xX
XxFran10xX deleted the followup/sealed-artifact-alignment branch October 21, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant