fix(csv): keep document opening on the main actor - #2600
Open
salmonumbrella wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
NSDocument's default serial-read behavior.Why
Opening a CSV or TSV on macOS 27 can terminate TablePro with
EXC_BREAKPOINT/SIGTRAP, with_dispatch_assert_queue_failand_swift_task_checkIsolatedSwiftreached from theNSDocumentControlleropening queue. Under Swift 6,NSDocumentis main-actor isolated, butCSVDocumentopted into concurrent reads, allowing AppKit to open it on a background queue. Removing that override restores the framework default and keeps document construction and reading on the actor AppKit requires. This matches the underlying AppKit concurrency issue tracked in Apple Feedback #38.Usage
No usage change.
Verification
git diff --check origin/main..HEAD: pass.Serial document opening can make existing up-front row indexing visible on the main actor for very large files. Moving that indexing behind an async boundary is separate work; this PR restores actor correctness without widening scope.