Repository navigation
Adding a staging environment for docs - #421
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://blue-island-085db6f03-421.westeurope.6.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://blue-island-085db6f03-421.westeurope.6.azurestaticapps.net |
Metallist1
changed the title
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://blue-island-085db6f03-421.westeurope.6.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://blue-island-085db6f03-421.westeurope.6.azurestaticapps.net |
mlonsk
left a comment
mlonsk
left a comment
There was a problem hiding this comment.
Good idea overall, but as written there's no working production gate yet, and production no longer waits for the quality checks. Inline comments cover the details. A few points that don't map to a line:
- Orphaned previews: PRs that are still open when this merges keep their preview environments on the old production SWA, because
close_previewnow uses the TEST token. They'll need deleting by hand in Azure. - Old secret:
AZURE_STATIC_WEB_APPS_API_TOKEN_DELIGHTFUL_MUD_081AFFE03is no longer referenced. Can you confirmAZURE_SWA_TOKEN_PRODpoints to the same SWA (delightful-mud)? If it does, delete the old secret after merge. - Preview limit: which plan is the test SWA on? Free allows 3 preview environments and Standard allows 10. Past that limit, PR preview deploys fail.
- Custom domain: is docs-staging.tabulareditor.com already bound to the test SWA?
- Merge: please squash-merge. The history has "Temp fix" / "Temp solution" commits, and the branch name
feature/docs-migrationdoesn't describe the change.
Co-authored-by: Morten Lønskov <morten.lonskov@tabulareditor.com>
Co-authored-by: Morten Lønskov <morten.lonskov@tabulareditor.com>
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://blue-island-085db6f03-421.westeurope.6.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://blue-island-085db6f03-421.westeurope.6.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://blue-island-085db6f03-421.westeurope.6.azurestaticapps.net |
2 participants
Adding a staging environment for docs.
Now when we merge to main, the changes will deploy to docs-staging.tabulareditor.com which is our PRE environment.
A PR that merged to main will have a gated step to push to Prod. (IE. docs.tabulareditor.com). This should prevent us from pushing code that is incomplete.