Repository navigation
feat: secure BigQuery connection credentials - #2
Conversation
|
Reopening to rerun CI now that the registry accepts connection_fields. |
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
CRITICAL: For connections created through the new UI,
This silently defeats the credential-rotation flow this PR introduces. The fix is one line: in Files Reviewed (18 files)
Cross-checked unchanged file Fix these issues in Kilo Cloud Reviewed by kimi-k3 · Input: 406.8K · Output: 13.3K · Cached: 210.4K |
Summary
Compatibility
This change does not require migration of existing connections. The driver reads the new secure
credentialextra first and falls back to the existing Password value when it is absent.Older hosts ignore the additive
connection_fieldsmanifest property. When the secure secret API is unavailable, the UI continues to direct users to Password.Validation
pnpm --dir ui install --frozen-lockfilepnpm --dir ui typecheckpnpm --dir ui buildcargo test --all-targetscargo clippy --all-targets -- -D warningscargo fmt --all -- --checkcargo build --releaseDependencies
Publishing this manifest requires the corresponding Tabularis host support in TabularisDB/tabularis#629 and an update to the Tabularium driver schema so that
connection_fieldsis accepted by the registry validator.Closes #1