Repository navigation
fix(api): import bounties into the server's configured database - #30
Merged
Merged
Conversation
The importer connected to DATABASE_URL, but the server connects to database.url from the instance config.json, so on an installed instance it could seed a different (stale) database. Use the same config, falling back to DATABASE_URL, print which database it uses, and report would-be counts on --dry-run.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
import:bountiesscript from #29 connected toDATABASE_URL. The server connects todatabase.urlfrom the instanceconfig.json(apps/api/src/index.ts:196). On the production podDATABASE_URLpoints to/data/registry.db, so the import could have seeded the wrong database.DATABASE_URLonly when the instance has no config.--dry-runnow reports the counts it would apply.Tested against a temporary instance whose
config.jsonpoints to one SQLite file whileDATABASE_URLpoints to a non-existent one. The script used theconfig.jsondatabase: the dry run reported 31 created, then the real run created 31.